ejabberd pull requests

[Randy Barlow]

Greetings!

In November I pulled the ejabberd SELinux policy into Fedora 27+ so I
could manage it more closely with ejabberd updates. At the time I sent
pull requests to the Fedora SELinux policy to remove it from there, but
the pull requests haven't been reviewed or merged. Could someone take a
look?

https://github.com/fedora-selinux/selinux-policy-contrib/pull/38
https://github.com/fedora-selinux/selinux-policy-contrib/pull/39

At this point, I suppose we'll also want to make this change on the
Fedora 28 branch.

You can see the policy in the ejabberd sources now:

https://src.fedoraproject.org/rpms/ejabberd/tree/master
_______________________________________________
selinux mailing list -- ***@lists.fedoraproject.org
To unsubscribe send an email to selinux-***@l

[Randy Barlow]

Post by Randy Barlow
In November I pulled the ejabberd SELinux policy into Fedora 27+ so I
could manage it more closely with ejabberd updates. At the time I sent
pull requests to the Fedora SELinux policy to remove it from there, but
the pull requests haven't been reviewed or merged. Could someone take a
look?
https://github.com/fedora-selinux/selinux-policy-contrib/pull/38
https://github.com/fedora-selinux/selinux-policy-contrib/pull/39
At this point, I suppose we'll also want to make this change on the
Fedora 28 branch.
https://src.fedoraproject.org/rpms/ejabberd/tree/master

Could someone look at my PRs?
_______________________________________________
selinux mailing list -- ***@lists.fedoraproject.org
To unsubscribe send an email to selinux-***@lists.fedoraproject.o

[Lukas Vrabec]

Post by Randy Barlow

Post by Randy Barlow
In November I pulled the ejabberd SELinux policy into Fedora 27+ so I
could manage it more closely with ejabberd updates. At the time I sent
pull requests to the Fedora SELinux policy to remove it from there, but
the pull requests haven't been reviewed or merged. Could someone take a
look?
https://github.com/fedora-selinux/selinux-policy-contrib/pull/38
https://github.com/fedora-selinux/selinux-policy-contrib/pull/39
At this point, I suppose we'll also want to make this change on the
Fedora 28 branch.
https://src.fedoraproject.org/rpms/ejabberd/tree/master

Could someone look at my PRs?

Sorry for late late late answer, but yes, I'll look on it.

Did you follow these steps? [1]

Also, we have several macros which will help you with installing own
SELinux module[2].

[1]
https://fedoraproject.org/wiki/PackagingDrafts/SELinux_Independent_Policy

[2] https://github.com/fedora-selinux/selinux-policy-macros

Thanks,
Lukas.

_______________________________________________
--
Lukas Vrabec
Software Engineer, Security Technologies
Red Hat, Inc.
_______________________________________________
selinux mailing list -- ***@lists.fedoraproject.org
To unsubscribe send an email to selinux-***@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/***@lists.fedorapro

[R P Herrold]

Post by Randy Barlow

Post by Randy Barlow
https://github.com/fedora-selinux/selinux-policy-contrib/pull/38
https://github.com/fedora-selinux/selinux-policy-contrib/pull/39
https://src.fedoraproject.org/rpms/ejabberd/tree/master

Could someone look at my PRs?

Thank you, Randy, for a full and sequential patch as a 'worked
example' which shows 'grafting' a selinux sub-package into a
.spec file


A question: Looking at the patches, and then a local system, I
see a
couple of other 'selinux-policy-*' packages available:

selinux-policy-minimum.noarch
selinux-policy-mls.noarch

but I see in the .spec file patch

103 + Requires: selinux-policy
104 + Requires: selinux-policy-targeted

I understand the first, as it provides the base for the other
three alternatives

But the URL referenced by the selinux spec file is dead:
http://oss.tresys.com/repos/refpolicy/

as to reading about what they provide (the sub-package
descriptions are not helpful)

Should the line 104 provide for any of those three to satisfy
its 'Require'?

-- Russ herrold
_______________________________________________
selinux mailing list -- ***@lists.fedoraproject.org
To unsubscribe send an email to selinux-***@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/***@lists.fedoraproject.org/message/LW2PTYKTBFD7XW7S

[Adam Przybyla]

BTW, there is an old version of ejabberd selinux policy you can take a look:
https://github.com/AdamPrzybyla/ejabberd-selinux
Regads
Adam Przybyla

Post by R P Herrold

Post by Randy Barlow

Post by Randy Barlow
https://github.com/fedora-selinux/selinux-policy-contrib/pull/38
https://github.com/fedora-selinux/selinux-policy-contrib/pull/39
https://src.fedoraproject.org/rpms/ejabberd/tree/master

Could someone look at my PRs?

Thank you, Randy, for a full and sequential patch as a 'worked
example' which shows 'grafting' a selinux sub-package into a
.spec file
A question: Looking at the patches, and then a local system, I
see a
selinux-policy-minimum.noarch
selinux-policy-mls.noarch
but I see in the .spec file patch
103 + Requires: selinux-policy
104 + Requires: selinux-policy-targeted
I understand the first, as it provides the base for the other
three alternatives
http://oss.tresys.com/repos/refpolicy/
as to reading about what they provide (the sub-package
descriptions are not helpful)
Should the line 104 provide for any of those three to satisfy
its 'Require'?
-- Russ herrold
_______________________________________________
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
lists.fedoraproject.org/message/LW2PTYKTBFD7XW7SZNNBF3XXKJ5NUUXZ/

[Randy Barlow]

Post by Lukas Vrabec
Sorry for late late late answer, but yes, I'll look on it.
Did you follow these steps? [1]
Also, we have several macros which will help you with installing own
SELinux module[2].

I should also apologize for my long time to reply - I've been on
vacation for a long time. I almost forgot how to computer :)

I replied to your comments:

https://github.com/fedora-selinux/selinux-policy-contrib/pull/38

I also made a PR against ejabberd to get it to use the macros:

https://src.fedoraproject.org/rpms/ejabberd/pull-request/4

If you are a proven packager and agree with that PR, feel free to merge,
fix the selinux_policyver global at the top to reference the selinux
policy version that's needed, and build. If you are a proven packager, I
should be available to coordinate doing this with you this week.

Is it OK if we do this only in Rawhide?
_______________________________________________
selinux mailing list -- ***@lists.fedoraproject.org
To unsubscribe send an email to selinux-***@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/***@lists.fedoraproject.org/message/GEM3PFOCXPXRUPDPSWUQB4ZRX